creating new feature/discover-interface branch #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinCounts
reviewed
Jun 27, 2024
| #['ls', '-l','--time-style=+"%Y-%m-%d %H:%M:%S "'] | ||
|
|
||
| # B ~ 'arg_validator' | ||
| def inspect_discover_args_valid(arg): |
There was a problem hiding this comment.
Is this just a placeholder function for later validation logic?
There was a problem hiding this comment.
Correct. This was left as a placeholder as I worked out the main functionality (the 'arg_parser' in part C). I need to revisit this. Thank you for bringing to my attention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the changes to multiple scripts which allow the observation-inventory-utils to work on Discover (NASA). AWS and HPSS functionality is preserved despite these edits.
(1) One new file has been added: discover_interface.py
(2) Changes were made to 5 scripts:
-inventory_table_factory.py
-nceplibs_bufr_cmd_handler.py
-obs_inv_queries.py
-obs_storage_platforms.py
-search_engine.py