You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You can run Noah-OM with nonsensical, inconsistent soil and land cover values. As we saw in NOAA-OWP/DMOD#472 (comment), this can lead to model errors.
Expected behavior
Noah-OM should not initialize if inconsistent values of land cover and soil are provided.
Suggested changes
I've flagged an issue on the hydrofabric repo, but we should also implement model-level sanity checks. These will stop initialization and throw an error message if land cover and soil are inconsistent.
Specifically, Noah-OM should check the values of isltyp and vegtyp for consistency. I provide example category lumpings in the linked hydrofabric issue above.
The text was updated successfully, but these errors were encountered:
Current behavior
You can run Noah-OM with nonsensical, inconsistent soil and land cover values. As we saw in NOAA-OWP/DMOD#472 (comment), this can lead to model errors.
Expected behavior
Noah-OM should not initialize if inconsistent values of land cover and soil are provided.
Suggested changes
I've flagged an issue on the hydrofabric repo, but we should also implement model-level sanity checks. These will stop initialization and throw an error message if land cover and soil are inconsistent.
Specifically, Noah-OM should check the values of
isltyp
andvegtyp
for consistency. I provide example category lumpings in the linked hydrofabric issue above.The text was updated successfully, but these errors were encountered: