Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion- use statement with only #78

Open
nmizukami opened this issue Aug 11, 2023 · 1 comment
Open

Suggestion- use statement with only #78

nmizukami opened this issue Aug 11, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@nmizukami
Copy link
Contributor

Hi @SnowHydrology and @GreyEvenson-NOAA,

Looking through the grid implementation (which looks great!), I noticed most of use statements do not have only,so just pointing to the module. By explicitly specifying public entities (subroutine, function or variables etc.) with only, it is easier to tell where the entities are coming from, and easier to trace the code, and also allow to avoid name conflict (can rename referred entities. As the codes get complex, this helps maintainability, code documentation without comments.

something to think about...

https://stackoverflow.com/questions/51686745/why-should-i-use-use-only-in-fortran

@nmizukami nmizukami added the enhancement New feature or request label Aug 11, 2023
@GreyREvenson
Copy link
Contributor

Hi @nmizukami,

Thanks for mentioning this and including the stackoverflow post. It's helpful/informative feedback! I'll add this to my to-do list.

@SnowHydrology has mentioned your expertise in this past. I hope to meet you at some point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants