Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove goto statements from source code #70

Open
SnowHydrology opened this issue May 3, 2023 · 0 comments
Open

Remove goto statements from source code #70

SnowHydrology opened this issue May 3, 2023 · 0 comments
Assignees
@andywood @SnowHydrology @GreyREvenson

Comments

@SnowHydrology
Copy link
Contributor

Work on the current NWM identified Fortran goto statements as a potential issue. Modern Fortran has moved away from goto statements for myriad reasons, some of which are discussed here.

There are three modules from which the gotos should be removed (https://github.com/NOAA-OWP/noah-owp-modular/search?q=goto):

Alternative solutions include do loops, if statements, cycle, exit, and case.

This issue also needs fixing in Sac-SMA and Snow-17.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andywood andywood

@SnowHydrology SnowHydrology

@GreyREvenson GreyREvenson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andywood @SnowHydrology @GreyREvenson