Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13pt] HV dropping CatFIM records inc Sea level sites #1274

Open
RobHanna-NOAA opened this issue Sep 2, 2024 · 1 comment · May be fixed by #1285
Open

[13pt] HV dropping CatFIM records inc Sea level sites #1274

RobHanna-NOAA opened this issue Sep 2, 2024 · 1 comment · May be fixed by #1285
Assignees
Labels
bug Something isn't working CatFIM NWS Flood Categorical HAND FIM FIM4 research

Comments

@RobHanna-NOAA
Copy link
Contributor

RobHanna-NOAA commented Sep 2, 2024

HydroVIS has a couple pieces of code where it drops records while loading loading library and sites data. This logic, if even valid anymore, should be in FIM code not HV. There are also places where it changes the status messages.

  1. Sea Levels
    for sea_level_site in ['qutg1', 'augg1', 'baxg1', 'lamf1', 'adlg1', 'hrag1', 'stng1']:
    if "sites" in file_handle:
    df.loc[df.ahps_lid==sea_level_site, 'mapped'] = 'no'
    df.loc[df.ahps_lid==sea_level_site, 'status'] = 'Stage thresholds seem to be based on sea level and not channel thalweg'
    else:
    df.loc[df.ahps_lid==sea_level_site, 'viz'] = 'no'
    df = df[df['viz']=='yes'] # Subset df to only sites desired for mapping

    (Notice the status change)


  1. Compare to a HV list named "aphs_restricted_sites" db. A separate card will be issued for that.

3). HV has a column named "viz"

Weird though: HV has this for Flow only.. hummm

  • Check to see if this is still needed, if the sites list is correct and add this logic to CatFIM code as/if applicable. Note: We have alot more ahps stage sites now so the list, if even needed, is likely out of data.
@RobHanna-NOAA RobHanna-NOAA added bug Something isn't working research CatFIM NWS Flood Categorical HAND FIM FIM4 labels Sep 2, 2024
@RobHanna-NOAA RobHanna-NOAA self-assigned this Sep 4, 2024
@RobHanna-NOAA RobHanna-NOAA changed the title [13pt] CatFIM Sea level sites [13pt] HV dropping CatFIM records inc Sea level sites Sep 23, 2024
@RobHanna-NOAA
Copy link
Contributor Author

With the addition of the WIP stage_based_ahps_restricted_sites.csv, it already had entries for the sites listed in the sea test above. So the sea level test need not be added directly in code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CatFIM NWS Flood Categorical HAND FIM FIM4 research
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants