Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename 'ks' variable in Pace #34

Open
bensonr opened this issue Oct 26, 2023 · 3 comments
Open

rename 'ks' variable in Pace #34

bensonr opened this issue Oct 26, 2023 · 3 comments

Comments

@bensonr
Copy link
Contributor

bensonr commented Oct 26, 2023

The ks variable in Pace and FV3 is supposed to designate the topmost layer in which the bk of the eta pair becomes zero. That layer and above is known as the sponge layer. It makes sense to rename the variable in Pace to be more descriptive as it does not have the same meaning as is and js.

@lharris4
Copy link

This variable may not be necessary for our current purposes; any model component that needs it can easily re-compute it from the ak/bk coefficients. So we could just remove it.

Minor correction: above ks is where the reference coordinate becomes a pure-pressure coordinate and surface pressure has no influence. It is not necessarily the sponge layer, in which additional damping is applied near the upper boundary.

@bensonr
Copy link
Contributor Author

bensonr commented Oct 26, 2023

@lharris4 - thanks for the clarifications! BTW, @oelbert and I chatted about the need for this variable and maybe removing it before deciding to open a discussion and get your input.

@lharris4
Copy link

lharris4 commented Oct 26, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants