Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid Type should be an enum #29

Open
oelbert opened this issue Oct 5, 2023 · 1 comment
Open

Grid Type should be an enum #29

oelbert opened this issue Oct 5, 2023 · 1 comment

Comments

@oelbert
Copy link
Contributor

oelbert commented Oct 5, 2023

The grid_type variable indicates what the model's grid geometry is, and is currently an int, in keeping with the Fortran code. The main distinction is if grid_type is 0, 1, or 2 that specifies a cubed-sphere geometry (only 0 is currently supported, the gnomonic equidistant cubed-sphere), and if grid_type is 3 or greater the model is run with an orthogonal doubly-periodic grid (typically set with grid_type=4). Pace doesn't need grid_type to be an integer, and for clarity we should switch to an enum that governs the grid type in the code first with gnomonic cubed sphere and orthogonal members.

@FlorianDeconinck
Copy link
Collaborator

Additionally, any functionality around the that grid_type (testing if it's <X or ==X) should be made into a well named method on the enum.

Bonus point for a good str, repr and docstring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants