Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish refactor of ppParser object #574

Closed
jtmims opened this issue May 23, 2024 · 1 comment
Closed

finish refactor of ppParser object #574

jtmims opened this issue May 23, 2024 · 1 comment

Comments

@jtmims
Copy link
Collaborator

jtmims commented May 23, 2024

Before the update, the MDTF was grabbing necessary information from a set filename template (i.e):
self.filename_template = ('{realm}.{time_range}.{variable_id}.{frequency}.nc' )

In an update, I converted this function into a base class (ppParserBase) that can be spun out depending on what DRS the user is using (i.e. ppParserGFDL) . Currently, the MDTF is acting in the former manner as it is implemented with the line:
entries = [e.cat_entry for e in list(map(util.catalog.ppParser['ppParser' + 'GFDL'], file_list))]

A final form of the refactor needs to be decided with templates for the varying DRS's. In the best case, this type of filename parsing might be able to be bypassed entirely. For example, the following might be needed to be included in the .jsonc file passed to the MDTF by the command-line:
"filename_template" : "{realm}.{time_range}.{variable_id}.{frequency}.nc"

@jtmims jtmims pinned this issue Jun 10, 2024
@jtmims jtmims unpinned this issue Jun 10, 2024
@jtmims
Copy link
Collaborator Author

jtmims commented Jun 10, 2024

Issues was fixed in #587

@jtmims jtmims closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant