Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files missed in .gitingore #2901

Closed
RussTreadon-NOAA opened this issue Sep 11, 2024 · 0 comments · Fixed by #2904
Closed

Files missed in .gitingore #2901

RussTreadon-NOAA opened this issue Sep 11, 2024 · 0 comments · Fixed by #2904
Assignees
Labels
bug Something isn't working

Comments

@RussTreadon-NOAA
Copy link
Contributor

What is wrong?

git status in an installed working copy of g-w develop at 6ea681b returns the following three files as untracked

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        parm/ufs/post_itag_gfs
        parm/ufs/postxconfig-NT-gfs.txt
        parm/ufs/postxconfig-NT-gfs_FH00.txt

These files are soft links to sorc/ufs_model.fd/tests/parm. These links were added to sorc/link_workflow.sh by PR #2877. There were not added to .gitignore.

What should have happened?

git status in an unmodified installed working copy of g-w develop should not return untracked files.

What machines are impacted?

All or N/A

Steps to reproduce

  1. clone g-w develop
  2. cd sorc/
  3. ./build_all.sh
  4. ./link_workflow.sh
  5. git status

git status will return three untracked files

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        parm/ufs/post_itag_gfs
        parm/ufs/postxconfig-NT-gfs.txt
        parm/ufs/postxconfig-NT-gfs_FH00.txt

Additional information

This is not a high priority item. It's a simple fix to remove unnecessary files from git status.

Do you have a proposed solution?

To remove these three untracked files from git status, add these three files to .gitignore

@@ -79,6 +79,9 @@ parm/ufs/MOM_input_*.IN
 parm/ufs/MOM6_data_table.IN
 parm/ufs/ice_in.IN
 parm/ufs/ufs.configure.*.IN
+parm/ufs/post_itag_gfs
+parm/ufs/postxconfig-NT-gfs.txt
+parm/ufs/postxconfig-NT-gfs_FH00.txt
 parm/wafs
 
 # Ignore sorc and logs folders from externals
@RussTreadon-NOAA RussTreadon-NOAA added bug Something isn't working triage Issues that are triage labels Sep 11, 2024
@DavidHuber-NOAA DavidHuber-NOAA self-assigned this Sep 11, 2024
@DavidHuber-NOAA DavidHuber-NOAA removed the triage Issues that are triage label Sep 11, 2024
DavidNew-NOAA pushed a commit to DavidNew-NOAA/global-workflow that referenced this issue Sep 13, 2024
This adds 3 missing links from the UPP into parm/ufs to .gitignore.

Resolves NOAA-EMC#2901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants