Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocean_prod task not being triggered when REPLAY_ICS is set to YES #2725

Closed
EricSinsky-NOAA opened this issue Jun 27, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@EricSinsky-NOAA
Copy link
Contributor

EricSinsky-NOAA commented Jun 27, 2024

What is wrong?

When REPLAY_ICS is set to YES, the ocean_prod tasks are not triggered.

What should have happened?

The ocean_prod tasks should run even when REPLAY_ICS is set to YES.

What machines are impacted?

All or N/A

Steps to reproduce

  1. Set REPLAY_ICS to YES in config.base.
  2. Make sure ocean is one of the components set to run in your experiment.
  3. Run global workflow using REPLAY ICs.

Additional information

This issue is caused by OFFSET_START_HOUR not being 0. This offset causes filename mismatches between the actual raw data being produced by MOM6 and the links produced by the global workflow. This mismatch results in ocean hist files not being saved in COMROOT, resulting in the ocean_prod task dependencies not being satisfied.
MOM6_output_bug

Do you have a proposed solution?

A fix has been added in PR #2680. In this fix, a separate diag_table file has been created that is only used when OFFSET_START_HOUR is not 0. This diag_table allows the correct filenames to be produced by MOM6 (see image below). In this fix, when OFFSET_START_HOUR is 3 and FHOUT_OCN is 6, the first lead time is averaged from f003 to f009, the second lead time is averaged from f006 to f012, the third lead time is averaged from f012 to f018, and so on.
image

@EricSinsky-NOAA EricSinsky-NOAA added bug Something isn't working triage Issues that are triage labels Jun 27, 2024
@EricSinsky-NOAA EricSinsky-NOAA changed the title ocean_prod task not being triggered when REPLAY_ICS is set to YES Ocean_prod task not being triggered when REPLAY_ICS is set to YES Jun 27, 2024
@EricSinsky-NOAA
Copy link
Contributor Author

Update: A proposed fix for this has been moved from PR #2680 to PR #2755.

@WalterKolczynski-NOAA WalterKolczynski-NOAA removed the triage Issues that are triage label Jul 22, 2024
WalterKolczynski-NOAA added a commit that referenced this issue Aug 13, 2024
This PR fixes a couple issues that arise when replay initial conditions
are used. These issues only occur when `REPLAY_ICS` is set to `YES` and
`OFFSET_START_HOUR` is greater than `0`. The following items are
addressed in this PR.

1. Fix issue that causes ocean_prod tasks not to be triggered (issue
[#2725](#2725)). A new
diag_table was added (called `diag_table_replay`) that is used only when
`REPLAY_ICS` is set to `YES`. This diag_table accounts for the offset
that occurs when using replay IC's.
2. Fix issue that causes atmos_prod tasks not to be triggered for the
first lead time (e.g. f003) (issue
[#2754](#2754)). When
`OFFSET_START_HOUR` is greater than `0`, the first `fhr` is
`${OFFSET_START_HOUR}+(${DELTIM}/3600)`, which is defined in
`forecast_predet.sh` and will allow data for the first lead time to be
generated. The filename with this lead time will still be labelled with
`OFFSET_START_HOUR`.
3. Minor modifications were made to the extractvars task so that atmos
data from replay cases can be processed.

This PR was split from PR #2680. 

Refs #2725, #2754 

---------

Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
@EricSinsky-NOAA
Copy link
Contributor Author

This issue has been resolved with the merging of PR #2755. Closing as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants