-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing CICE hist files when cycle is not t00z and FHOUT_GFS_ICE is 24 #2674
Comments
Can the output be 6 hrs, and a post-processing step be applied to do the averaging for 12hrs or 24hrs? |
Since we can assign an FHOUT specifically for CICE now using
A fix has been made in the workflow so that the first filename is labelled as 12h instead of 24h in cases where
That is correct. The last lead time that is generated for CICE when |
An issue has been opened in UFS that relates to this one. |
May I ask if a "forecast day" history stream would work?
rather than try to workaround calendar days. |
@NickSzapiro-NOAA I believe these are the settings I have been using. Here is the problematic output on WCOSS2 for a 2021032312 case where
|
Thank you, @EricSinsky-NOAA . I think the problem is that 'h' is still calendar based. May I ask if ufs-community/ufs-weather-model#2437 works for you as well? Something like
where histfreq_n needs to be the number of timesteps in 24hr |
Thank you for fixing this, @NickSzapiro-NOAA. After testing
Some adjustments will need to be made on the global-workflow side, but it looks like the root of the problem was fixed in your ufs-weather-model branch. |
Good to hear! Thanks for checking! |
# Description The main purpose of this PR is to remove the need for an ice_prod dependency check script `ush/check_ice_netcdf.sh`. The original purpose of the ice_prod dependency check script is to check for special case dependencies where `( cyc + FHMIN ) % FHOUT_ICE )) =! 0` (more details on this issue can be found in issue #2674 ). A bugfix for these special cases is expected to come from a PR in the ufs-weather-model. Resolves #2721 Refs #2721, #2674
@EricSinsky-NOAA The CICE timestep stream was merged in ufs-weather-model |
What is wrong?
For cases where
FHOUT_GFS_ICE
is 24 and initialized at a time that is not 00Z, CICE files are not properly linked to COMROOT. This results in missing CICE hist files in COMROOT. After investigating this issue on WCOSS2, this happens because the raw CICE output is not averaged for a full 24 hours for the first lead time. For example, if the initialization time is 12Z and FHOUT_GFS_ICE is 24, the first lead time will only be averaged from 12Z to 00Z. Subsequent lead times are averaged from 00Z to 00Z. The global-workflow predetermines that the CICE output will be averaged from 12Z to 12z, which results in the global workflow creating links that do not match the raw CICE filenames, resulting in the CICE output not to save in COMROOT.What should have happened?
It may be ideal that CICE be averaged for a full 24 hours for the first lead time. For example, if the initialization time is 12Z and
FHOUT_GFS_ICE
is 24, the first lead time should be averaged from 12Z to 12Z. Subsequent lead times should be averaged from 12Z to 12Z. An alternative positive outcome would be for the global-workflow to correctly predetermine the name of the CICE output in these particular cases.What machines are impacted?
WCOSS2
Steps to reproduce
FHOUT_GFS_ICE
to 24 inconfig.base
.Additional information
This issue has been tested on WCOSS2, but it most likely impacts all platforms. The list of CICE output below illustrates how the global-workflow is not picking up the raw CICE output.
Do you have a proposed solution?
This issue has been initially addressed in PR #2561. In this PR, CICE_predet and CICE_postdet were modified so that the global-workflow can correctly predetermine the name of the raw CICE output (as illustrated in the image below). Also, the oceanice prod task was modified accordingly to account for the CICE filename changes in these cases. However, further fixes will need to be made to consider cases where
FHMIN
is not 0.The text was updated successfully, but these errors were encountered: