Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NCEPLIBS-external updates #94

Closed
wants to merge 53 commits into from
Closed

NCEPLIBS-external updates #94

wants to merge 53 commits into from

Conversation

kgerheiser
Copy link
Contributor

Merge release/public-v2 into develop.

Fix failing Github workflow by building MPI on macOS. Some Homebrew update causes MPI not to be found. It's good to test it both ways anyway.

Make HDF5 depend on MPI to ensure correct build order and add_custom_target(mpi) earlier in the script.

Set MPI_<lang>_COMPILER when building MPI so that variable is set.

Fixes #93

Fixes #92 (It builds on the runner and on my personal machine, with and without building MPI)

Fixes #85

Might need to cleanup the documentation some. I didn't handle the conflicts in too much depth.

climbfuji and others added 30 commits September 10, 2020 16:53
@climbfuji
Add option to create modules to release/public-v2
a16c548
@climbfuji
Remove submodule wgrib2
43d50d7
@climbfuji
Correct ESMF version in CMakeLists.txt
34ccfa9
@climbfuji
Update doc/README_???.txt for jet.intel, hera.intel, hera.gnu; add re…
9fd2fce 
…minders for all other platforms to update the documentation for release/public-v2
@climbfuji
Remove doc/README_endeavor_intel.txt, update doc/README_orion_intel.txt
e348546
@climbfuji
Merge pull request #68 from climbfuji/remove_wgrib2_now_in_nceplibs
c5d6b17 
release/public-v2: remove wgrib2 (now in NCEPLIBS)
@climbfuji
Update documentation for all remaining platforms, add instructions fo…
8f27b8d 
…r odin.intel and for docker (initial version)
@climbfuji
Minor bugfixes in documentation
c8e2e4f
@climbfuji
Merge pull request #69 from climbfuji/doc_update_release_public_v2_20…
b7a12bd 
…200917

release/public-v2: documentation update
@climbfuji
Update documentation to check out tag ufs-v2.0.0 of ufs-weather-model
45f960e
@climbfuji
Merge pull request #71 from climbfuji/doc_update_20200922
c2d8339 
Update documentation to check out tag ufs-v2.0.0 of ufs-weather-model
@climbfuji
tmplModulefiles/netcdf: add the install bin directory to PATH, requir…
0b01c9d 
…ed for SRW App workflow
@climbfuji
Merge pull request #72 from climbfuji/netcdf_module_add_path
05506dd 
tmplModulefiles/netcdf: add the install bin directory to PATH, required for SRW App workflow
@RatkoVasic-NOAA
Add wcoss dell instructions.
af31842
@climbfuji
Bugfixes in top-level CMakeLists.txt for building MPI, HDF5 and NetCDF
684e2e9
@DomHeinzeller
Build static jpeg library
3f05a05
@DomHeinzeller
Update instructions for macOS with clang+gfortran to solve OpenMP lin…
89ff203 
…ker issue
@climbfuji
Merge pull request #77 from climbfuji/mpi_bugfixes_release_public_v2
4d538f0 
release/public-v2: bugfixes for building MPI, HDF5 and NetCDF
@RatkoVasic-NOAA
Add INSTALL_PREFIX for ufs-weather-model
5a0fd9a 
Point INSTALL_PREFIX to preinstalled libraries.
@climbfuji
Merge pull request #74 from RatkoVasic-NOAA/release/public-v2
3d080e8 
Add wcoss dell instructions.
@climbfuji
Turn DEPLOY on by default
4a42c06
@climbfuji
Update install documentation for macOS with gcc+gfortran and clang+gf…
ac88461 
…ortran
@climbfuji
Remove manual NCEPLIBS-external cmake config file (left from release/…
a281624 
…public-v1), create libjpeg and jasper modules
@climbfuji
Update README for gaea.intel and jet.intel
55136b7
@climbfuji
Update README for hera.intel and orion.intel
075284b
@climbfuji
Update README for stampede.intel and orion.intel
d95cd1f
@climbfuji
Update README for cheyenne.intel, cheyenne.gnu, hera.gnu
a1e177e
@climbfuji
Update README for odin.intel and wcoss_dell_p3
1745c0c
@climbfuji
Fix travis tests
8bbabcf
@climbfuji
Update README for ubuntu.gnu and wcoss_dell_p3.intel
37237d0
RatkoVasic-NOAA and others added 19 commits November 6, 2020 19:54
@RatkoVasic-NOAA
Added new INSTALL_PREFIX path to doc/README_wcoss_cray_intel.txt
e1e33c4
@kgerheiser
Merge pull request #86 from RatkoVasic-NOAA/release/public-v2
44269f8 
Update documentation for WCOSS Cray for release/public-v2
@climbfuji
Update GNU compiler on Cheyenne to 10.1.0
50a7194
@climbfuji
Merge pull request #88 from climbfuji/cheyenne_gnu_10
bf66cb8 
release/public-v2: Update GNU compiler on Cheyenne to version 10.1.0 (documentation update only)
@climbfuji
Update install instructions for macOS, Ubuntu and Redhat to include a…
4ea139a 
…ll Python modules required to use the plotting scripts
@climbfuji
Fix travis ci tests on macOS
60d72aa
@climbfuji
Update instructions for docker/ubuntu with gnu
f9e5c4b
@climbfuji
Merge pull request #90 from climbfuji/final_doc_update_srw_20210225
f607061 
release/public-v2: final documentation updates for the SRW App release 1.0.0 - documentation updates only
@climbfuji
Fix formatting in final version of doc/README_docker_gnu.md
cfcabe6
@climbfuji
Address all reviewer comments except one
e4a8e53
@SamuelTrahanNOAA
Changes to sections 5 & 6 of docker instructions, due to reviewer com…
2ae87eb 
…ments in #91
@climbfuji
Merge pull request #2 from SamuelTrahanNOAA/release/public-v2
0ecfd04 
Changes to sections 5 & 6 of docker instructions, due to reviewer comment
@climbfuji
Merge pull request #91 from climbfuji/docker_doc_final_20210301
0dbbfd0 
release/public-v2: final updates to Docker documentation before release
@kgerheiser
Add MPI dependency
210ea35
@kgerheiser
Merge release/public-v2 into develop
e9c7bd3
@kgerheiser
Remove duplicate module deploy
ef35477
@kgerheiser
Build MPICH because using Homebrew MPI fails
f054ef6
@kgerheiser
Remove cat in workflow files
55acef2
@kgerheiser
Fix MPI build logic
b5af046
@kgerheiser kgerheiser requested a review from climbfuji April 13, 2021 19:24
@kgerheiser
Copy link
Contributor Author

@climbfuji

Have you ever seen this error before error: invalid argument '-std=c++11' not allowed with 'C' when building ESMF with Clang? I don't normally use Clang. The clang + gfortran test build fails because of it.

@climbfuji
Copy link
Collaborator

@climbfuji

Have you ever seen this error before error: invalid argument '-std=c++11' not allowed with 'C' when building ESMF with Clang? I don't normally use Clang. The clang + gfortran test build fails because of it.

I think yes, but I don't remember ... is it possible that it doesn't find the correct CXX compiler?

@climbfuji
Copy link
Collaborator

@kgerheiser what should we do with this old PR?

@edwardhartnett
Copy link
Collaborator

Whoops. I should not have approved this...

@climbfuji
Copy link
Collaborator

@kgerheiser @edwardhartnett What should we do with this PR?

@kgerheiser
Copy link
Contributor Author

I don't know. I don't really want to develop NCEPLIBS-external anymore if we don't have to. If it's pertinent I can try to complete this PR and get develop updated with the ufs-v2.0.0 changes.

@climbfuji
Copy link
Collaborator

I don't know. I don't really want to develop NCEPLIBS-external anymore if we don't have to. If it's pertinent I can try to complete this PR and get develop updated with the ufs-v2.0.0 changes.

I guess this is up to @edwardhartnett to decide. I doubt we'll ever need it again. With the two upcoming MRW and SRW releases, the previous ones won't be supported any longer and NCEPLIBS-external won't be needed.

@edwardhartnett
Copy link
Collaborator

edwardhartnett commented Mar 28, 2022 •
edited
Loading

We certainly want to retire NCEPLIBS-external as soon as feasible.

@kgerheiser kgerheiser closed this by deleting the head repository Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardhartnett edwardhartnett edwardhartnett approved these changes

@climbfuji climbfuji Awaiting requested review from climbfuji

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@kgerheiser @climbfuji @edwardhartnett @RatkoVasic-NOAA @DomHeinzeller @SamuelTrahanNOAA