Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files in the same folder can take precedence over validphys scripts' files #55

Open
scarlehoff opened this issue Nov 14, 2022 · 3 comments

Comments

@scarlehoff
Copy link
Member

If one runs a validphys script (for instance vp-comparefits) in a folder where there is already a report.md file. This report.md will take precedence over the one define in the script.

Not sure whether this is something that should be fixed in reportengine or in validphys.

@Zaharid
Copy link
Contributor

Zaharid commented Nov 14, 2022

The code would be here

finder = filefinder.FallbackFinder([

but I am not sure this should be changed. For one it works so that it is easy to reproduce something from the output folder. Better ideas welcome.

@scarlehoff
Copy link
Member Author

scarlehoff commented Nov 14, 2022

I think in the case of a script the templates defined in the script should take precedence. There's no reason I should know the names used in the script to avoid them in the folder which I'm running from.

I would've expect a crash or at least a warning if there's an ambiguity, no silently getting the wrong result. In any case I'll transfer the issue to the RE repository then.

@scarlehoff scarlehoff transferred this issue from NNPDF/nnpdf Nov 14, 2022
@Zaharid
Copy link
Contributor

Zaharid commented Nov 14, 2022

Comparefits is a bit of a special case in that the filename is harcoded in the script. In the flow it was designed for, the filename is supposed to be relative to the current path. If you were writing a vp runcard and the template was randomly pulled from elsewhere that would be confusing. So I guess some other mechanism would be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants