Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom vocabulary classes naming error #22

Open
tsepton opened this issue Jun 20, 2023 · 0 comments
Open

Custom vocabulary classes naming error #22

tsepton opened this issue Jun 20, 2023 · 0 comments

Comments

@tsepton
Copy link

tsepton commented Jun 20, 2023

Inside BertUncasedCustomVocabulary.cs, I would expect to see the declaration for a class extending UncasedTokenizer, however the class has the following signature public class BertCasedCustomVocabulary : CasedTokenizer.

Something similar happens inside BertCasedCustomVocabulary.cs, where the class signature is public class BertUnasedCustomVocabulary : CasedTokenizer
tsepton added a commit to tsepton/BertTokenizers that referenced this issue Jun 20, 2023
@tsepton
Fix wrong naming NMZivkovic#22
89f8cf3
@tsepton tsepton mentioned this issue Jun 20, 2023
Open
@tsepton tsepton changed the title Custom cocabulary classes naming error Custom vocabulary classes naming error Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tsepton