-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: HTTP serve validation results with Last-Modified header field #469
Comments
That sounds like a good idea, indeed! We will try and implement it in 0.9. We should also support If-Modified-Since and ETags. |
...and If-None-Match, if you provide Etags... |
Note: Rust newbie. The code that serves the ROAs is easy to find. However, despite reading a lot, I couldn't quite figure out the "right" way to format a timestamp as an HTTP date. Is this functionality present in the libraries Routinator uses already? |
Yes, most date and time handling is done using the chrono crate. I believe |
Unfortunately no; see https://greenbytes.de/tech/webdav/rfc7231.html#preferred.date.format. So it seems we'll need to come up with the correct format string for that... |
Shouldn’t be too difficult. However, I would prefer using an array of formatting items rather than a string since the latter needs to be parsed. We’re already using this strategy to generate the timestamp in the csvext format in output.rs. |
Ah, more pointers! Appreciated. I'll give it a try soonish. |
Send Last-Modified response header field with validation result (fixes #469)
I’d like to keep the issue open for support of ETags, If-Modified-Since, and If-None-Match. (Client-side suppor for ETags in RRDP is supposed to be added for 0.9 as well, so this can all be ein aufwasch.) |
I'm currently running tests with various validators, GETting JSON output and post-processing it. It would be very useful if the JSON output would be served with a Last-Modified header field, indicating the time when the last validation run finished.
(see also cloudflare/cfrpki#83)
The text was updated successfully, but these errors were encountered: