Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnknownRecordData should not be used to copy records from one message to another #430

Open
Philip-NLnetLabs opened this issue Oct 29, 2024 · 0 comments
Labels
documentation enhancement New feature or request

Comments

@Philip-NLnetLabs
Copy link
Member

UnknownRecordData is not safe when copying records from one message to another. The reason is that some record types may contain compressed names. When these are copied as UnknownRecordData, the compression pointer may point to something different in the new message.

The solution is to create a new type that know about all record types that contain names that may be compressed and is generic for all other types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant