Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Move print calls to the noodles logger #85

Open
BvB93 opened this issue May 19, 2022 · 1 comment · May be fixed by #86
Open

ENH: Move print calls to the noodles logger #85

BvB93 opened this issue May 19, 2022 · 1 comment · May be fixed by #86

Comments

@BvB93
Copy link

BvB93 commented May 19, 2022

As a feature request, would noodles be open for moving the print calls, scattered throughout the codebase, to the its logger?

The problem with directly dumping it in the stdout is the lack of downstream control over the output streams, an issue that manifests itself when, e.g. using the likes of pytest, resulting in a very messy output (see below).

If you're open to the suggestion then I'd very much like to create a PR.

Examples

test/test_read_cp2k_basis.py ..
test/test_schemas.py .
test/test_tools.py .
test/test_version.py .s...
Uncaught error running job: 139837629376704, Shapes do not match (existing (80,) vs new (100,))
Flushing queue and waiting for threads to close.
test/test_workflow_IPR.py Exception of type <class 'TypeError'> :
Shapes do not match (existing (80,) vs new (100,))
F
Uncaught error running job: 139837627987088, Shapes do not match (existing (80,) vs new (100,))
Flushing queue and waiting for threads to close.
test/test_workflow_coop.py Exception of type <class 'TypeError'> :
Shapes do not match (existing (80,) vs new (100,))
F
@jhidding
Copy link
Member

I would welcome a PR to this effect.

@BvB93 BvB93 linked a pull request May 25, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants