Create login page #1394

pedroafmonteiro · 2024-11-19T12:09:10Z

Closes #1375

Login page layout
Widgets (Login, Remember, Problems and Terms and Conditions) new design
Implement splash screen
Login with credentials popup

To implement the splash screen

To add the gradient and animation to the splash screen I needed to add this package, because it allow us to create a splash screen with custom widgets for the gradients and the animation: https://pub.dev/packages/another_flutter_splash_screen This was accomplished without adding the package.
The native splash screen was replaced by the same background color as the new splash and login page with a transparent logo image through this package. I think that, before, both the android and ios splash screens were implemented manually, but this package does that automatically with a simple configuration in the pubspec.yaml file: https://pub.dev/packages/flutter_native_splash

Review checklist

Terms and conditions reflect the current change
Contains enough appropriate tests
If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
Properly adds an entry in changelog.md with the change
If PR includes UI updates/additions, its description has screenshots
Behavior is as expected
Clean, well-structured code

…d the widgets positions. Co-authored by: Granja5 <[email protected]>

packages/uni_app/lib/view/login/login.dart

codecov · 2024-11-23T20:56:54Z

Codecov Report

Attention: Patch coverage is 3.75000% with 154 lines in your changes missing coverage. Please review.

Project coverage is 12%. Comparing base (eded9d6) to head (dfcb039).
Report is 23 commits behind head on ui/redesign.

Additional details and impacted files

@@             Coverage Diff             @@
##           ui/redesign   #1394   +/-   ##
===========================================
- Coverage           12%     12%   -0%     
===========================================
  Files              270     271    +1     
  Lines             7282    7341   +59     
===========================================
+ Hits               808     812    +4     
- Misses            6474    6529   +55

pedroafmonteiro · 2024-11-23T20:58:37Z

I implemented the splash screen without the "another_flutter_splash_screen" package.
There's an issue though. A black screen appears between the Splash Screen view and the next screen (login or homepage)

…sh screen still exists and appears after the native one. flutter_native_splash package was added to the project.

…into separate widget classes in the widget folder for better modularity and code organization.

…cified that only underlined text activates the button.

…ents

…Login Text

…when the language is changed

… The animation in the logo now works flawlessly.

pedroafmonteiro · 2024-12-04T16:03:31Z

~~there's a linting problem, as Tween() asks for doubles, but if I put ints, it gives an error and I can't cast it as Animation because it stops working~~
it's now fixed, but login_old.dart is giving problems now

thePeras · 2024-12-08T21:45:56Z

@pedroafmonteiro if login_old.dart is giving you problems and isn't bing use, just delete it!

…s not being used.

thePeras · 2024-12-09T17:48:39Z

If it's already ready to review, just convert the PR to "already to review". I am excited to look into this.

pedroafmonteiro · 2024-12-09T17:50:41Z

The login with credentials popup is the only thing left. It should be done between today and tomorrow!

vitormpp · 2024-12-27T17:47:22Z

Altough this is not the primary purpose of this PR (and you haven't changed this code), i think there are some issues in the login that need to be addressed here or in a new issue:

in _login method, we clear text controllers twice after a successful login; also, the switch lacks break statements;
in fa_login the string 'Failed to authenticate' is hardcoded; we should use something like ToastMessage.error(context, S.of(context).failed_login) (as we do in login function)

thePeras

✅ 🛫

packages/uni_app/lib/view/login/login.dart

DGoiana · 2025-01-02T17:55:38Z

It looks pretty neat! Just check out the comments above, remove unneeded comments and we're ready to merge it!

…ach.

DGoiana

🚀

pedroafmonteiro added 2 commits November 19, 2024 12:02

Initial version of the new login page. Changed to stack and refactore…

0b7b4f0

…d the widgets positions. Co-authored by: Granja5 <[email protected]>

Reformatted code.

099a2cc

DGoiana reviewed Nov 19, 2024

View reviewed changes

packages/uni_app/lib/view/login/login.dart Outdated Show resolved Hide resolved

DGoiana reviewed Nov 19, 2024

View reviewed changes

packages/uni_app/lib/view/login/login.dart Outdated Show resolved Hide resolved

pedroafmonteiro linked an issue Nov 20, 2024 that may be closed by this pull request

Implement new login page #1375

Open

Added new splash screen view.

d4dfc52

pedroafmonteiro and others added 12 commits November 23, 2024 21:11

Updated native splash screen to a solid background color. Custom spla…

5601349

…sh screen still exists and appears after the native one. flutter_native_splash package was added to the project.

Fixed AndroidManifest.xml

5955992

Added code for edge to edge effect.

86762ae

Login Page slight visual changes and text updated

4debdaa

Login Page visuals almost finished

aba6cc6

Refactor createSaveDataCheckBox, createAFLogInButton, and createLink …

8ca9a65

…into separate widget classes in the widget folder for better modularity and code organization.

Refactor createTermsAndConditionsButton into own widget class and spe…

cecbdee

…cified that only underlined text activates the button.

Corrected some visual inconsistencies of the login page widget compon…

770a31a

…ents

Sigarra Login SVG now supports two colors and Updated the Portuguese …

c1dadb2

…Login Text

Padding corrections to ensure the login page layout keeps consistent …

7d610df

…when the language is changed

Reworked the transition between the splash screen and the login page.…

9205446

… The animation in the logo now works flawlessly.

Fixed formatting.

2bbb8b5

Fixed linting problem.

7ba2e64

removed login_old.dart file as it is causing linting problems and it'…

934eff8

…s not being used.

pedroafmonteiro and others added 4 commits December 17, 2024 11:17

New Login with Credentials popup (not finished)

f17ed15

Working on the inputs of the Dialog Box

81dbf8e

Merge branch 'ui/redesign' into redesign/login-page

c81dc50

Removed Useless Code

26dad35

pedroafmonteiro and others added 6 commits December 17, 2024 17:44

Fixed styles to be applied from theme.dart in uni_ui.

4fad010

Added the correct Themes

4b1feb6

Changed the size of the Dialog Box Sized Boxes

182847b

Fixed remember me checkbox color.

2023c16

Fixed padding on the alternative login popup.

12a2211

Fixed formatting.

b678a7a

pedroafmonteiro marked this pull request as ready for review December 18, 2024 11:01

pedroafmonteiro requested a review from a team December 18, 2024 11:01

Reimplemented native splash screen.

0c4ac26

thePeras approved these changes Dec 30, 2024

View reviewed changes

Readded portrait screen orientation in AndroidManifest.

eded9d6

DGoiana reviewed Jan 2, 2025

View reviewed changes

packages/uni_app/lib/view/login/login.dart Outdated Show resolved Hide resolved

DGoiana reviewed Jan 2, 2025

View reviewed changes

packages/uni_app/lib/view/login/login.dart Outdated Show resolved Hide resolved

pedroafmonteiro added 10 commits January 2, 2025 22:50

Text controllers were being cleared twice. That has been fixed.

eb8def7

Added break statement to the switch in the _login method.

bd4e374

Fixed hardcoded string in fa_login method.

330e0d6

Removed use of WidgetStateProperty for ElevatedButton.styleFrom appro…

90f185b

…ach.

Removed unecessary code.

b169bed

Removed unecessary code.

1901df6

Removed duplicated string from intl.

f2b08cf

Merge branch 'ui/redesign' into redesign/login-page

1e483fc

Fixed intl strings.

c7aa9d5

Formatted code.

dfcb039

DGoiana approved these changes Jan 3, 2025

View reviewed changes

DGoiana merged commit d608c5e into ui/redesign Jan 3, 2025
6 checks passed

DGoiana deleted the redesign/login-page branch January 3, 2025 02:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create login page #1394

Create login page #1394

pedroafmonteiro commented Nov 19, 2024 •

edited

Loading

codecov bot commented Nov 23, 2024 •

edited

Loading

pedroafmonteiro commented Nov 23, 2024

pedroafmonteiro commented Dec 4, 2024 •

edited

Loading

thePeras commented Dec 8, 2024 •

edited

Loading

thePeras commented Dec 9, 2024

pedroafmonteiro commented Dec 9, 2024

vitormpp commented Dec 27, 2024 •

edited

Loading

thePeras left a comment

DGoiana commented Jan 2, 2025

DGoiana left a comment

Create login page #1394

Create login page #1394

Conversation

pedroafmonteiro commented Nov 19, 2024 • edited Loading

To implement the splash screen

Review checklist

codecov bot commented Nov 23, 2024 • edited Loading

Codecov Report

pedroafmonteiro commented Nov 23, 2024

pedroafmonteiro commented Dec 4, 2024 • edited Loading

thePeras commented Dec 8, 2024 • edited Loading

thePeras commented Dec 9, 2024

pedroafmonteiro commented Dec 9, 2024

vitormpp commented Dec 27, 2024 • edited Loading

thePeras left a comment

Choose a reason for hiding this comment

DGoiana commented Jan 2, 2025

DGoiana left a comment

Choose a reason for hiding this comment

pedroafmonteiro commented Nov 19, 2024 •

edited

Loading

codecov bot commented Nov 23, 2024 •

edited

Loading

pedroafmonteiro commented Dec 4, 2024 •

edited

Loading

thePeras commented Dec 8, 2024 •

edited

Loading

vitormpp commented Dec 27, 2024 •

edited

Loading