diff --git a/.github/workflows/quality_checks.yml b/.github/workflows/quality_checks.yml index b170054..7b1c24c 100644 --- a/.github/workflows/quality_checks.yml +++ b/.github/workflows/quality_checks.yml @@ -58,8 +58,14 @@ jobs: - name: run unit tests run: make test + - name: debug + run: ls coverage + - name: SonarCloud Scan uses: SonarSource/sonarcloud-github-action@master + with: + args: > + -Dsonar.verbose=true env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} diff --git a/sonar-project.properties b/sonar-project.properties index 0ca8e86..2dfb2f8 100644 --- a/sonar-project.properties +++ b/sonar-project.properties @@ -4,3 +4,4 @@ sonar.host.url=https://sonarcloud.io sonar.coverage.exclusions=**/*.test.*,**/jest.config.ts,scripts/* sonar.javascript.lcov.reportPaths=coverage/lcov.info +sonar.sources=. diff --git a/src/live-spine-client.ts b/src/live-spine-client.ts index 1cdf4a3..959d568 100644 --- a/src/live-spine-client.ts +++ b/src/live-spine-client.ts @@ -6,7 +6,7 @@ import axios, {Axios, AxiosRequestConfig, AxiosResponse} from "axios" import {APIGatewayProxyEventHeaders} from "aws-lambda" // timeout in ms to wait for response from spine to avoid lambda timeout -const SPINE_TIMEOUT = 45000 +const SPINE_TIMEOUT = 43000 export class LiveSpineClient implements SpineClient { private readonly SPINE_URL_SCHEME = "https" @@ -76,7 +76,7 @@ export class LiveSpineClient implements SpineClient { timeout: SPINE_TIMEOUT }) - // This can be removed when https://nhsd-jira.digital.nhs.uk/browse/AEA-3448 is complete + // This can be removed when https://nhsd-jira.digital.nhs.uk/browse/AEA-3448 is complete change comment if ( response.data["statusCode"] !== undefined && response.data["statusCode"] !== "1" &&