From ed235add37d2d41ec78192ea0485874120fe37ee Mon Sep 17 00:00:00 2001
From: Kris Szlapa <kris.szlapa1@nhs.net>
Date: Thu, 1 Feb 2024 09:13:23 +0000
Subject: [PATCH] Move sonarcloud steps to within quality check job

---
 .github/workflows/quality_checks.yml | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/.github/workflows/quality_checks.yml b/.github/workflows/quality_checks.yml
index 50f5b64..45cff85 100644
--- a/.github/workflows/quality_checks.yml
+++ b/.github/workflows/quality_checks.yml
@@ -11,7 +11,7 @@ on:
         required: true
 
 jobs:
-  lint_build_test:
+  quality_checks:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
@@ -54,20 +54,9 @@ jobs:
 
       - name: run build
         run: make build
-        shell: bash
 
       - name: run unit tests
         run: make test
-        shell: bash
-
-  sonarcloud:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
-        with:
-          ref: ${{ inputs.BRANCH_NAME }}
-          fetch-depth: 0
 
       - name: SonarCloud Scan
         uses: SonarSource/sonarcloud-github-action@master