Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead fuels never actually consumed in fires #1301

Closed
adrifoster opened this issue Dec 11, 2024 · 0 comments · Fixed by #1302
Closed

Dead fuels never actually consumed in fires #1301

adrifoster opened this issue Dec 11, 2024 · 0 comments · Fixed by #1302

Comments

@adrifoster
Copy link
Contributor

adrifoster commented Dec 11, 2024

@glemieux and I figured out today that patch%fuel%frac_burnt(:) is always set to 0.0 due to this line..

if(i_disturbance_type .ne. dtype_ifire) then
 currentPatch%fuel%frac_burnt(:) = 0._r8
end if

The i_disturbance_type is in a loop on all disturbance types, including dtype_ifire. dtype_ifire is a constant (2). The first dtype is ifall, thus the first time we traverse this loop, every %patch%fuel%frac_burnt(:) will be set to 0.0.

So from what @glemieux and I can see - fuel is never consumed and sent to the atmosphere. So any time we have a fire, ALL the fuel on the old patch is transferred to the new patch.

I imagine this will result in fairly large changes.

@github-project-automation github-project-automation bot moved this from ❕Todo to ✔ Done in FATES issue board Jan 3, 2025
glemieux added a commit to glemieux/fates that referenced this issue Jan 4, 2025
Bug fix for issue NGEET#1301

Corrects when the fraction of burnt fuel is zero'd and how the litter
mass is updated based on that fraction.
glemieux added a commit to ckoven/fates that referenced this issue Jan 13, 2025
Bug fix for issue NGEET#1301

Corrects when the fraction of burnt fuel is zero'd and how the litter
mass is updated based on that fraction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant