Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the testing code to be agnostic to the host land model #1265

Open
glemieux opened this issue Oct 21, 2024 · 0 comments
Open

Refactor the testing code to be agnostic to the host land model #1265

glemieux opened this issue Oct 21, 2024 · 0 comments
Labels
host land model A broader catch-all tag for all host land models type: enhancement type: refactor Restructures code without changing functionality type: testing Related to improvements in code testing (e.g. unit, regression, etc)

Comments

@glemieux
Copy link
Contributor

The current implementation of the fates testing infrastructure assumes that the tests will be run within ctsm:

fates/testing/path_utils.py

Line 23 in f5bd625

cime_path = os.path.join(path_to_fates_root(), "../../cime")

Ideally this would be updated to be agnostic to the host land model or allow the tests to take the cime location as an argument.
@glemieux glemieux added type: enhancement HLM: ctsm An issue is related to ctsm host land model or a particular PR has a corresponding ctsm-side PR HLM: e3sm An issue is related to e3sm host land model or a particular PR has a corresponding e3sm-side PR type: testing Related to improvements in code testing (e.g. unit, regression, etc) labels Oct 21, 2024
@glemieux glemieux added type: refactor Restructures code without changing functionality host land model A broader catch-all tag for all host land models and removed HLM: ctsm An issue is related to ctsm host land model or a particular PR has a corresponding ctsm-side PR HLM: e3sm An issue is related to e3sm host land model or a particular PR has a corresponding e3sm-side PR labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
host land model A broader catch-all tag for all host land models type: enhancement type: refactor Restructures code without changing functionality type: testing Related to improvements in code testing (e.g. unit, regression, etc)
Projects
FATES issue board
Status: ❕Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glemieux