enforce lowlevel ciphers for legacy environments by ctx.set_ciphers #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martialblog
reviewed
Oct 30, 2024
| @@ -171,6 +171,7 @@ def get_data(base_url, timeout, insecure): | |||
| # Default context for connection | |||
| ctx = ssl.create_default_context() | |||
| if insecure is True: | |||
| ctx.set_ciphers("DHE-RSA-AES256-GCM-SHA384:@SECLEVEL=1") | |||
There was a problem hiding this comment.
Any reason for this specific cipher?
If possible, we want to use something as broad as possible, that works for everyone
There was a problem hiding this comment.
I took this specific cipher due to the output of openssl s_client --connect smsgw1.invalid.local:443 --cipher 'ALL:@SECLEVEL=1'
However, i am pretty sure any of the ciphers on the medium level would fit:
There was a problem hiding this comment.
I think that might be too specific for your use case/
Suggested change
| ctx.set_ciphers("DHE-RSA-AES256-GCM-SHA384:@SECLEVEL=1") | |
| ctx.set_ciphers("ALL:@SECLEVEL=0") |
If we can do something like this, that would probably work for most users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20