Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate project data from project metadata #418

Open
elliotBraem opened this issue Jun 19, 2024 · 2 comments
Open

Separate project data from project metadata #418

elliotBraem opened this issue Jun 19, 2024 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@elliotBraem
Copy link
Contributor

Currently, we duplicate the project metadata inside the stringified value, and in the metadata itself.

{
  "devs.near": {
    "project": {
      "build-gateway": {
        "": "{\"title\":\"Build Gateway\",\"description\":\"Building the site\",\"profileImage\":\"\",\"backgroundImage\":\"\",\"tags\":{\"community\":\"\",\"open-source\":\"\",\"dao\":\"\"},\"linktree\":{\"twitter\":\"NearBuilders\",\"github\":\"nearbuilders/gateway\",\"telegram\":\"builddao\",\"website\":\"https://www.nearbuilders.org\"},\"contributors\":[\"devs.near\"],\"tabs\":[\"overview\",\"tasks\",\"activity\"],\"projectAccountId\":\"builddao.near\",\"teamSize\":\"\",\"location\":\"\"}",
        "metadata": {
          "name": "Build Gateway",
          "description": "Building the site",
          "image": "",
          "backgroundImage": "",
          "tags": {
            "community": "",
            "open-source": "",
            "dao": ""
          },
          "linktree": {
            "twitter": "https://twitter.com/NearBuilders",
            "github": "https://github.com/nearbuilders/gateway",
            "telegram": "https://t.me/builddao",
            "website": "https://www.nearbuilders.org"
          }
        }
      }
    },
    "builddao.near": {
      "project": {
        "devs.near_project_build-gateway": ""
      }
    }
  }
}

We should no longer duplicate this data and reference the respective origins. Project cards, quickview, and profile will need to be updated to reflect this

@elliotBraem elliotBraem added the bug Something isn't working label Jun 19, 2024
@elliotBraem elliotBraem added this to the v2 milestone Jun 19, 2024
@Megha-Dev-19
Copy link
Collaborator

@elliotBraem so we want to have to only inside metadata? and not inside stringified value, or the other way around?

@elliotBraem
Copy link
Contributor Author

elliotBraem commented Jun 19, 2024

I think metadata fields should only be inside metadata

Social.get([
${accountId}/project/${projectId},
${accountId}/project/${projectId}/metadata/**
]);

While project specific data like contributors should be in the project itself

Although I think this is a ticket to implement after tests have been completed for project card, project quickview, and project page

@elliotBraem elliotBraem self-assigned this Jun 19, 2024
@elliotBraem elliotBraem moved this to In Progress in Build DAO Gateway Jun 19, 2024
@elliotBraem elliotBraem removed their assignment Jun 19, 2024
@Jikugodwill Jikugodwill self-assigned this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants