Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to numpy version 2 #318

Open
davidhassell opened this issue Jan 15, 2025 · 5 comments
Open

Move to numpy version 2 #318

davidhassell opened this issue Jan 15, 2025 · 5 comments
Labels
enhancement New feature or request

Comments

@davidhassell
Copy link
Contributor

cfdm currently fails for numpy 2.0.0 (release notes), released 16 Jun 2024.

We need to fix this.

I'm in favour of only supporting numpy v2. A whole bunch of our other new dependencies are for versions June 2024 or later, so I don't see the problem in only supporting numpy from that time, too.

@davidhassell davidhassell added the enhancement New feature or request label Jan 15, 2025
@davidhassell
Copy link
Contributor Author

Having had look, the call signature of some methods will have to change (e.g. __array__), so supporting both would be tricky ...

@davidhassell
Copy link
Contributor Author

davidhassell commented Jan 15, 2025

Looking through the numpy 2 migration guide: https://numpy.org/devdocs/numpy_2_0_migration_guide.html, I think it should quite straight forward.

PR to follow (but not until the CFA PR has been merged)

@sadielbartholomew
Copy link
Member

Thanks David. Note some folk noticed Numpy-2 related issues downstream in cf-python so I created a label on that Issue Tracker: https://github.com/NCAS-CMS/cf-python/labels/numpy-2. Only one open at the moment, I see, but we should check it gets resolved before we convince ourselves we're comaptible with Numpy 2.

@davidhassell
Copy link
Contributor Author

Thanks for the cross-reference. The changes for cfdm turned out to be minimal - I'm assuming that the same will be True for cf-python (... but am wondering whether all of cf-python's dependencies are v2 yet, ESMF?)

@sadielbartholomew
Copy link
Member

sadielbartholomew commented Jan 15, 2025

I'm assuming that the same will be True for cf-python

Hopefully! But would be good to check 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants