-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to numpy version 2 #318
Comments
Having had look, the call signature of some methods will have to change (e.g. __array__), so supporting both would be tricky ... |
Looking through the PR to follow (but not until the CFA PR has been merged) |
Thanks David. Note some folk noticed Numpy-2 related issues downstream in cf-python so I created a label on that Issue Tracker: https://github.com/NCAS-CMS/cf-python/labels/numpy-2. Only one open at the moment, I see, but we should check it gets resolved before we convince ourselves we're comaptible with Numpy 2. |
Thanks for the cross-reference. The changes for cfdm turned out to be minimal - I'm assuming that the same will be True for cf-python (... but am wondering whether all of cf-python's dependencies are v2 yet, ESMF?) |
Hopefully! But would be good to check 🙂 |
cfdm
currently fails fornumpy
2.0.0 (release notes), released 16 Jun 2024.We need to fix this.
I'm in favour of only supporting numpy v2. A whole bunch of our other new dependencies are for versions June 2024 or later, so I don't see the problem in only supporting numpy from that time, too.
The text was updated successfully, but these errors were encountered: