Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure test coverage for MusicBox #160

Closed
Tracked by #157
boulderdaze opened this issue May 17, 2024 · 2 comments · Fixed by #178
Closed
Tracked by #157

Ensure test coverage for MusicBox #160

boulderdaze opened this issue May 17, 2024 · 2 comments · Fixed by #178
Assignees
Labels
enhancement New feature or request

Comments

@boulderdaze
Copy link
Collaborator

boulderdaze commented May 17, 2024

Acceptance Criteria

  • Make sure the tests are well-structured and achieve comprehensive test coverage

Ideas

  • Fix the test failure: test_chapman.py, test_full_gas_phase_mechanism.py
  • Add testing for any parts of the python wrapper that don't yet have tests
@boulderdaze boulderdaze mentioned this issue May 17, 2024
11 tasks
@boulderdaze boulderdaze changed the title Test Ensure test coverage for MusicBox May 17, 2024
@carl-drews
Copy link
Collaborator

Here is what the test failures look like under my new Windows install:

C:\2024\MusicBox\music-box\tests>pytest
======================== test session starts ====================================
platform win32 -- Python 3.12.3, pytest-8.2.2, pluggy-1.5.0
rootdir: C:\2024\MusicBox\music-box
configfile: pyproject.toml
collected 4 items

test_analytical.py . [ 25%]
test_chapman.py F [ 50%]
test_full_gas_phase_mechanism.py F [ 75%]
test_wall_loss.py .
. . .

@K20shores
Copy link
Collaborator

The tests could be failing because they are comparing against data we saved. It's possible that was from an early version of the python written music box and had some errors. If you can compare it to the output of the web version of musicbox and it's close enough, then you can use the current output of the python model as the expected results

@K20shores K20shores self-assigned this Aug 8, 2024
@K20shores K20shores linked a pull request Aug 9, 2024 that will close this issue
@K20shores K20shores added the enhancement New feature or request label Aug 9, 2024
@K20shores K20shores added this to the MusicBox IGAC Demo milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants