Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpas_atm refactor to use state structure module #780

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

hkershaw-brown
Copy link
Member

@hkershaw-brown hkershaw-brown commented Dec 9, 2024

Description:

Refactor mpas_atm model_mod to use state_structure, remove progvar to vector.

Fixes issue

Various mpas_atm issues, notes in #753
fixes #523,
fixes #389
fixes #781
#624, #768

note on subroutines, functions in mpas_atm model_mod refactor vs removed vs unchanged

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

MPAS model_mod_check and filter

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

Note still have clamp or fail being read but not used #624
Removed state_vector_to_boundary_file  and update_wind_components so I can compile with debugging flags
see comment #753 (comment)

Remove not used variables:
add_static_data_to_diags  - not used
ew_boundary_type, ns_boundary_type  -not used

 Shortened some very verbose comments.
statevector_to_boundary_file and statevector_to_analysis file need to be done.
set ids array to length nc rather than 3
Q. Are there any surface obs that are not required for RTTOV?
QTY_CLOUD_FRACTION is also limited to 1
@hkershaw-brown
Copy link
Member Author

mpas code from MPAS-Model in DART repo is missing the MPAS-Model is missing the LICENCE.

moved MPAS-model code to a directory with the LICENCE for the code
from https://github.com/MPAS-Dev/MPAS-Model/blob/master/LICENSE

fixes #781
todo: wind, domain_id
see #753 (comment)
for various notes on update_mpas_states
have netcdf utitilies module for this
update_u_from_reconstruct  passing this namelist option publically.
I am not sure why this is a model_mod option rather than an update_mpas_states
option? To make people set it for filter?
#753 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mpas Model for Prediction Across Scales (MPAS)
Projects
None yet
1 participant