Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify user if using RTPS inflation that QCEFF options ignored for posterior inflation #785

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hkershaw-brown
Copy link
Member

Description:

If RTPS inflation is selected, the probit inflation qceff options are silently ignored for posterior inflation.
This pull request adds a message from filter to notify the user, and adds a note in the qceff docs about RTPS.

Fixes issue

fixes #748

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.

Run lorenz_96_tracer with RTPS inflation (posterior inf_flavor = 4) to check the message is printed (and not printed for post inf_flavor /= 4)

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

…rior inflation

Note in qceff docs about RTPS
fixes #748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QCEFF RTPS inflate
1 participant