Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill Obs with reduced mangitude #346

Open
1 of 3 tasks
mkelley opened this issue Jun 7, 2022 · 0 comments
Open
1 of 3 tasks

Fill Obs with reduced mangitude #346

mkelley opened this issue Jun 7, 2022 · 0 comments
Labels
feature request request for new functionality

Comments

@mkelley
Copy link
Member

mkelley commented Jun 7, 2022

An idea from @mschwamb

This is a request for

  • a new feature
  • an enhancement to existing sbpy functionality
  • somethings else: [explain here]

The requested changes will be implemented by
Maybe the LSST SSSC?

High-level concept
Implement a method that can compute reduced/absolute magnitude for an Obs object with photometry and ephemeris information.

Explain the relevance to sbpy
Very much a solar system problem.

Proposal details
H = m - 5 log10(rh * delta) + 2.5 log10(Phi(phase))

Example (pseudo-)code
Just pitching a possible API, based on the Ephem.fill_delta_and_phase method proposed in PR #339:

Obs = ...

Obs.fill_absolute_magnitude()  # for H(1,1,alpha)

phase_function_model = HG(G=0.19)
Obs.fill_absolute_magnitude(phase_function_model)  # for H(1,1,0)
@mkelley mkelley added the feature request request for new functionality label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request request for new functionality
Projects
None yet
Development

No branches or pull requests

1 participant