Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate host names in the JobAggregate when aggregating across hosts #23

Closed
Tracked by #6 ...
lars-t-hansen opened this issue Aug 4, 2023 · 3 comments
Closed
Tracked by #6 ...
Assignees
Labels
resolution:wontfix This will not be worked on task:enhancement New feature or request

Comments

@lars-t-hansen
Copy link
Collaborator

When jobs span hosts we want the host names to be aggregated in the JobAggregate, for subsequent analysis and display.

@lars-t-hansen
Copy link
Collaborator Author

It is possible (#24 (comment)) that we don't want to do this naively, though, but may instead want each job to have some kind of joint aggregated data but also a per-host breakdown of some of the data. So don't do this until we have figured that out.

@lars-t-hansen lars-t-hansen removed the component:sonarlog sonalyze/sonarlog/* label Aug 17, 2023
@lars-t-hansen
Copy link
Collaborator Author

Also, aggregating the hosts is sort of annoyingly expensive, requiring a hash set or similar structure for disambiguation and an array for the result, with strings probably allocated for all the elements of the array unless we optimize with a string pool. At the moment we only do this for display, which is fine, but if we were to do it for many more records it would be good to consider the costs.

@lars-t-hansen lars-t-hansen added the resolution:wontfix This will not be worked on label Aug 18, 2023
@lars-t-hansen
Copy link
Collaborator Author

It's OK for now to do this when we print, and not sooner. Ditto for the GPU sets.

@lars-t-hansen lars-t-hansen closed this as not planned Won't fix, can't repro, duplicate, stale Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:wontfix This will not be worked on task:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant