Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sawdust should have forge:dusts/wood tag #5

Open
LlubNek opened this issue Apr 17, 2021 · 1 comment · May be fixed by LlubNek/MysticalMachinery#1
Open

sawdust should have forge:dusts/wood tag #5

LlubNek opened this issue Apr 17, 2021 · 1 comment · May be fixed by LlubNek/MysticalMachinery#1

Comments

@LlubNek
Copy link

LlubNek commented Apr 17, 2021

MysticalMachinery sawdust has the forge:dusts/wooden tag.
Everybody else (thermal, mekanism, and immersive engineering) is using 3 tags for sawdust: forge:dusts, forge:dusts/wood, and forge:sawdust.
Recipes all use forge:dusts/wood

Also, this causes JAOPCA to add a "Block of Wooden" made of nine of your sawdust, in addition to the "Block of Wood" for other sawdusts.

Edit: mysticalmachinery-1.16.4-0.0.3.9.jar on MC 1.16.5, forge 36.1.4

@noobanidus
Copy link
Collaborator

noobanidus commented Apr 18, 2021

While I appreciate the request in the intent that it was filed, I struggle with it for a couple of reasons.

I will get around to changing this at some point in the future (because I agree that wood makes sense), but for the time being I recommend using a data pack to create this tag for it.

Most of my frustration over this stems not only because my mod was released months before all three of the mods you referenced, but that the main reference I found in Forge at the time was sticks: forge:rods/wooden. I was just following the standard, even if people now reckon that standard is invalid because they chose something different and they're popular enough to say "no, I am the standard".

Alternately, you're welcome to file a PR that makes the change.

@LlubNek LlubNek linked a pull request Apr 19, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants