Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default value for epochs #263

Open
1 task done
Tzal3x opened this issue Oct 18, 2024 · 2 comments · Fixed by #267
Open
1 task done

Remove default value for epochs #263

Tzal3x opened this issue Oct 18, 2024 · 2 comments · Fixed by #267
Assignees
Labels
enhancement New feature or request site-builder ux

Comments

@Tzal3x
Copy link
Collaborator

Tzal3x commented Oct 18, 2024

Description

While using devnet we would not specify the number of epochs and the walrus blobs would not get deleted.

Now with testnet we have to specify a number of epochs in publish command, otherwise it will default to 1.

Some users might not expect this kind of behaviour, so we should shed some light to it with a warning like "WARN: no number of epochs specified, defaulting to 1".

Having a default value to the epochs param, can result in deletion of sites while users might not expect this.

Component

site-builder

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@Tzal3x Tzal3x added enhancement New feature or request site-builder labels Oct 18, 2024
@Tzal3x Tzal3x self-assigned this Oct 18, 2024
@giac-mysten
Copy link
Collaborator

I think we should just have no default

@Tzal3x
Copy link
Collaborator Author

Tzal3x commented Oct 21, 2024

Ok then, sounds good.

@Tzal3x Tzal3x changed the title Add warning when the default epochs argument is used Remove default value for epochs Oct 21, 2024
@Tzal3x Tzal3x added the ux label Oct 21, 2024
@Tzal3x Tzal3x linked a pull request Oct 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request site-builder ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants