Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Walrus Site Builder config path to the error output #176

Open
1 task done
kkomelin opened this issue Aug 21, 2024 · 2 comments
Open
1 task done

Add Walrus Site Builder config path to the error output #176

kkomelin opened this issue Aug 21, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kkomelin
Copy link

kkomelin commented Aug 21, 2024

Description

Currently Wallet and Walrus config paths are printed to the console in case of error.
Example:

#...
Caused by:
    running the command exited with error: 2024-08-21T12:41:29.735851Z  INFO walrus: running in JSON mode
    2024-08-21T12:41:29.735925Z  INFO walrus_service::client::cli_utils: using Walrus configuration from '/home/kos/.walrus/client_config.yaml'
    2024-08-21T12:41:29.735979Z  INFO walrus_service::client::cli_utils: Using wallet configuration from /home/kos/suibase/workdirs/testnet/config/client.yaml
    2024-08-21T12:41:29.737098Z  INFO walrus_service::client::cli_utils: using RPC URL set in wallet configuration
    Error: the specified Walrus system object 0x0e37ebae146052248fef02853b39e05b75e8c6d22a074db170aad053429618ba does not exist; make sure you have the latest configuration and you are using the correct Sui network
    

It would be good to have the Walrus Site Builder config path there as well, for example:

(time) INFO walrus_service::client::cli_utils: Using site-builder configuration from ./site-builder.yaml

The motivation here is that with this number of config files, it's easy to accidentally mix up the paths, and this change can help to investigate the issue.

Component

site-builder

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@kkomelin kkomelin added the enhancement New feature or request label Aug 21, 2024
@giac-mysten
Copy link
Collaborator

@kkomelin good point! We can add that for sure.

@giac-mysten giac-mysten added the good first issue Good for newcomers label Aug 22, 2024
@kkomelin
Copy link
Author

Thank you @giac-mysten !

@Tzal3x Tzal3x changed the title [Feature]: Add Walrus Site Builder config path to the error output Add Walrus Site Builder config path to the error output Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants