Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should ScionPacket* be a ScionPacket<T>? #81

Open
mlegner opened this issue Dec 5, 2023 · 1 comment
Open

Should ScionPacket* be a ScionPacket<T>? #81

mlegner opened this issue Dec 5, 2023 · 1 comment
Milestone
Backlog

Comments

@mlegner
Copy link
Contributor

mlegner commented Dec 5, 2023

I see you opted for non-generic packet types, i.e., ScionPacketRaw vs ScionPacket<Raw> and ScionPacketUdp vs ScionPacket<Udp>. What prompted the choice?

Originally posted by @jpcsmith in #71 (comment)
@mlegner mlegner added this to the Backlog milestone Dec 5, 2023
@mlegner
Copy link
Contributor Author

mlegner commented Dec 22, 2023

#113 adds an additional ScionPacketScmp. It might make sense to at least consolidate the UDP and SCMP variants, as they share significant amounts of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@mlegner