Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is this usage of elliptic js lib concerning? #5

Open
stocks29 opened this issue Aug 3, 2022 · 1 comment
Open

is this usage of elliptic js lib concerning? #5

stocks29 opened this issue Aug 3, 2022 · 1 comment

Comments

@stocks29
Copy link

stocks29 commented Aug 3, 2022

https://github.com/stocks29/elliptic-test/blob/master/index.js

@kchalkias
Copy link
Contributor

Thanks for the feedback. You are correct!
There will be another list of vulnerable libs for which although their sign api is safe, they do allow generating keypairs from uncoupled, potentially unmatched, private and public key material. elliptic will unfortunately be enlisted in the second wave of vulnerable apis due to this. I'll keep this issue open and reference it when the second list is ready (soonish).

Btw, we mention this type of vulnerability in this Reddit post, see sub-points in last bullet-point and we'll need your contribution to find similar libs. Amazing input, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants