Fragment Caching
#1044
Replies: 2 comments 2 replies
-
|
I'm sorry to be negative, but almost nothing is going to work right now
because we customize the appearance of too much of the page. Obviously
language is a factor, but also things like location order, whether to
display authorities or not, all sorts of controls depend on whether the
user is the owner or not, logged in or not, theme, etc. etc. etc.
I've discussed at length a number of times how we can refactor the
structure of our views to move all user-specific formatting into the
browser so that the content the server sends out can be cached. I really
don't feel like writing it all up yet again. No one ever listens to me!
In short: yes, I've looked at fragment caching. It's a no go until we do
some major refactoring.
But prove me wrong. I would love nothing better!
…On Tue, Jun 21, 2022 at 11:39 PM andrew nimmo ***@***.***> wrote:
Has anyone tried implementing Rails native Fragment Caching
<https://guides.rubyonrails.org/v6.1/caching_with_rails.html#fragment-caching>
in the templates?
I'm going to try a PR against master right now -- please nominate your
toppermost expensive partials here. shared/matrix_box and everything on
show_observation seem like good places to start.
—
Reply to this email directly, view it on GitHub
<#1044>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYTNNOFU5QMS5W33L3Y3TDVQKDG7ANCNFSM5ZOVNEUA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
1 reply
-
|
Ok. Let's try it! Are there potential downsides? We can always revert... |
Beta Was this translation helpful? Give feedback.
-
|
I assume not... except the potential waste of your time!
…On Tue, Jun 21, 2022 at 11:52 PM andrew nimmo ***@***.***> wrote:
Ok. Let's try it! Are there potential downsides? We can always revert...
—
Reply to this email directly, view it on GitHub
<#1044 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYTNNOVM5LUWW3KIECCQATVQKEXFANCNFSM5ZOVNEUA>
.
You are receiving this because you commented.Message ID:
<MushroomObserver/mushroom-observer/repo-discussions/1044/comments/2998749
@github.com>
|
Beta Was this translation helpful? Give feedback.
1 reply
-
|
That's ok... took 5 minutes. Fire when ready! |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Has anyone tried implementing Rails native Fragment Caching in the templates?
I'm going to try a PR against master right now -- please nominate your toppermost expensive partials here. shared/matrix_box and everything on show_observation seem like good places to start.
Beta Was this translation helpful? Give feedback.
All reactions