Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not build on GCC #1

Open
michaelcmartin opened this issue Jan 23, 2016 · 2 comments
Open

Does not build on GCC #1

michaelcmartin opened this issue Jan 23, 2016 · 2 comments

Comments

@michaelcmartin
Copy link
Contributor

As noted in the release announcement, this doesn't yet build on GCC or MSVC. I've started looking into this, and the primary problem we have here is that extern functions are being declared inside the functions that use them, instead of in header files. Worse, some of them are being declared inconsistently (see, for instance, evaluateOperand, which takes two arguments when called but only one when defined.)

I'm working on cleaning this up in my fork so I can get a pull request out of it. I'm trying to make it a minimal set of changes, but even with that this will probably get us about halfway to ANSI C.

@mist64
Copy link
Contributor

mist64 commented Jan 23, 2016

Excellent!

@michaelcmartin
Copy link
Contributor Author

Pull Request #2 addresses this issue. I've tested it on Fedora 23 (gcc 5.3.1) and Ubuntu 14.04 (gcc 4.8.4). I encountered additional issues while testing this, but I get similar issues on a Mac on master, so I think they're unrelated. I'll be filing those shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants