Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name change profile migration not working correctly #329

Open
dumptruckman opened this issue Jun 17, 2019 · 18 comments · May be fixed by #362
Open

Name change profile migration not working correctly #329

dumptruckman opened this issue Jun 17, 2019 · 18 comments · May be fixed by #362
Labels
Bug: Confirmed Issue/problem with the software. Resolution: Accepted MV-Team is aware of the issue/PR and will be looking into it.

Comments

@dumptruckman
Copy link
Member

It seems that when a player changes their name their inventories data is not being properly migrated. In addition to making this work, some improvements would be needed. We need to create a migrated profile directory to store backups of profiles that get migrated. That way in case anything goes wrong we can manually restore data from the backups.

@dumptruckman dumptruckman added Bug: Confirmed Issue/problem with the software. Resolution: Accepted MV-Team is aware of the issue/PR and will be looking into it. labels Jun 17, 2019
@SlimeDog
Copy link

SlimeDog commented Jan 29, 2020

I assume this is due to storing inventories in

worlds/{WORLD}/{PLAYER_NAME}.json

instead of

worlds/{WORLD}/{PLAYER_UUID}.json

even though the mapping exists in

players/{PLAYER_UUID}.json

Migration would be unnecessary if inventory data were stored by UUID and then mapped back to the player name.

@Ichikuro
Copy link

Ichikuro commented Apr 2, 2020

Still a bug. Just caught it on my server. Went to find old players files, and are gone due to it knowing to switch to the UUID but the name didnt carry the files over...I'm guessing?

@nicegamer7 nicegamer7 linked a pull request May 13, 2020 that will close this issue
@nicegamer7 nicegamer7 pinned this issue May 17, 2020
@winnipeg21
Copy link

Sorry to revive old post. I too had/have this issue with players.

@SlimeDog
Copy link

I think it's safe to say that everyone does. Note that there is a PR pending.

@winnipeg21
Copy link

True, didn't see the PR on my phone lmao

@Thefirstalpha
Copy link

I have the same issue, still no fix?

@benwoo1110
Copy link
Member

There is a test build here if you want to try #362 (comment)

@benwoo1110
Copy link
Member

This PR #428 should have elevated most of the migration issue, do update to the latest test build to try. Appreciate anyone that happens to change their player name to report how it went.

@SlimeDog
Copy link

Thanks. I don't have any name changes pending. Hopefully, someone will.

@untuned
Copy link

untuned commented Nov 15, 2022

Just had an issue with this, luckily I was able to restore their inventory from a backup, but does anyone have a solution to this?

@nicegamer7
Copy link
Member

@untuned what version of MV Inventories were you using? This should be fixed as of 4.2.3, but if not, I had another unmerged change that could help.

@untuned
Copy link

untuned commented Nov 17, 2022

@untuned what version of MV Inventories were you using? This should be fixed as of 4.2.3, but if not, I had another unmerged change that could help.

[21:09:35 INFO]: Multiverse-Inventories version 4.2.4-SNAPSHOT-b524
[21:09:35 INFO]: Author: dumptruckman

@seema84
Copy link

seema84 commented Nov 2, 2023

so can we assume that mv inventories still can't deal with name changes?

@CloudeLecaw
Copy link

CloudeLecaw commented Nov 6, 2023

im using the last released version Multiverse-Inventories_4.2.6 i saw players inventories are saved with their name.. and or ith theire uuids?..

its confusing.. me

Here you see its stored by name..
image

and here by uuid...?
image

so if i change the name... does it convert this or renmae the files? or does it snyc with the players information stored in uuid?

its confusing me a bit..

what might i can asume what will happen...
player changes his name. and logs in world a
he has his inventory and all fine.. now he change to world b that has a seperate inventory...

because of the namechange the plugin might not see this other inventory anymore because it was made for the old name?

or does it rename all playername files from all worlds when player logs in?
would be a fair deal, even if direct uuid support would be better...

@VipelyRS
Copy link

im using the last released version Multiverse-Inventories_4.2.6 i saw players inventories are saved with their name.. and or ith theire uuids?..

its confusing.. me

Here you see its stored by name.. image

and here by uuid...? image

so if i change the name... does it convert this or renmae the files? or does it snyc with the players information stored in uuid?

its confusing me a bit..

what might i can asume what will happen... player changes his name. and logs in world a he has his inventory and all fine.. now he change to world b that has a seperate inventory...

because of the namechange the plugin might not see this other inventory anymore because it was made for the old name?

or does it rename all playername files from all worlds when player logs in? would be a fair deal, even if direct uuid support would be better...

name changing wipes your inventory :/

@CloudeLecaw
Copy link

awww thats sad to hear.. people love name changing :-(

@RayLumi
Copy link

RayLumi commented Sep 14, 2024

Is there a solution? I have the latest version and it still has this issue.
Multiverse-Core Version: 4.3.12

@RayLumi
Copy link

RayLumi commented Sep 14, 2024

changed to .13. Idk if its fixed though.
Multiverse-Core Version: 4.3.13
Multiverse-Inventories Version: 4.2.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Confirmed Issue/problem with the software. Resolution: Accepted MV-Team is aware of the issue/PR and will be looking into it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.