-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name change profile migration not working correctly #329
Comments
I assume this is due to storing inventories in
instead of
even though the mapping exists in
Migration would be unnecessary if inventory data were stored by UUID and then mapped back to the player name. |
Still a bug. Just caught it on my server. Went to find old players files, and are gone due to it knowing to switch to the UUID but the name didnt carry the files over...I'm guessing? |
Sorry to revive old post. I too had/have this issue with players. |
I think it's safe to say that everyone does. Note that there is a PR pending. |
True, didn't see the PR on my phone lmao |
I have the same issue, still no fix? |
There is a test build here if you want to try #362 (comment) |
This PR #428 should have elevated most of the migration issue, do update to the latest test build to try. Appreciate anyone that happens to change their player name to report how it went. |
Thanks. I don't have any name changes pending. Hopefully, someone will. |
Just had an issue with this, luckily I was able to restore their inventory from a backup, but does anyone have a solution to this? |
@untuned what version of MV Inventories were you using? This should be fixed as of 4.2.3, but if not, I had another unmerged change that could help. |
|
so can we assume that mv inventories still can't deal with name changes? |
awww thats sad to hear.. people love name changing :-( |
Is there a solution? I have the latest version and it still has this issue. |
changed to .13. Idk if its fixed though. |
It seems that when a player changes their name their inventories data is not being properly migrated. In addition to making this work, some improvements would be needed. We need to create a migrated profile directory to store backups of profiles that get migrated. That way in case anything goes wrong we can manually restore data from the backups.
The text was updated successfully, but these errors were encountered: