Thoughts on the Implementation of the Project

[jmatembu]

@MuhweziDeo

Thank you for the time you have put in this project. I would like to share my thoughts and general assessment of your input on the project.

Overall Remark:

Your code is good, and well organized. It generally follows good practices. With these skills you can practically contribute to projects of different levels of complexity.

What I liked:

• Practical git workflow for teams
• File and Folder organization
• Use of Repository pattern showed some practical knowledge of Design Patterns
• Good knowledge Events
• Proper of use of Middleware
• Simple use of user roles using Model methods is_admin() and isStaff()
• General extraction of validation logic to Form Request objects.

What I kinda did not like:

• The table structure for recording sale of items and service. Introduces multiple complexities.
• Minor cases of possible over-engineering for a simple project. A good example here is using of Form Request object for validation before creating service is not necessary since you are validating just two fields.
• No single test written