From d33c5a4fc65f1b86d408fd1ae43bdaad0147fc9f Mon Sep 17 00:00:00 2001 From: MregXN <46479059+MregXN@users.noreply.github.com> Date: Mon, 27 Nov 2023 20:46:27 +0800 Subject: [PATCH] fix flaky integration test DemoActorReminderOnceImpl (#553) * add undefined type Signed-off-by: MregXN * npm run pretty-fix Signed-off-by: MregXN * add undefind type for ttl Signed-off-by: MregXN * add undefind type Signed-off-by: MregXN * make type optional Signed-off-by: MregXN --------- Signed-off-by: MregXN --- daprdocs/content/en/js-sdk-docs/js-server/_index.md | 4 ++-- src/actors/runtime/AbstractActor.ts | 4 ++-- src/types/ActorReminder.type.ts | 2 +- src/types/ActorTimer.type.ts | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) mode change 100644 => 100755 src/actors/runtime/AbstractActor.ts mode change 100644 => 100755 src/types/ActorReminder.type.ts mode change 100644 => 100755 src/types/ActorTimer.type.ts diff --git a/daprdocs/content/en/js-sdk-docs/js-server/_index.md b/daprdocs/content/en/js-sdk-docs/js-server/_index.md index eaaba059..656a8f53 100644 --- a/daprdocs/content/en/js-sdk-docs/js-server/_index.md +++ b/daprdocs/content/en/js-sdk-docs/js-server/_index.md @@ -112,8 +112,8 @@ const daprServer = new DaprServer({ serverPort: "50002", // App Port serverHttp: myApp, clientOptions: { - daprHost, - daprPort, + daprHost + daprPort } }); diff --git a/src/actors/runtime/AbstractActor.ts b/src/actors/runtime/AbstractActor.ts old mode 100644 new mode 100755 index f42fbb98..18100142 --- a/src/actors/runtime/AbstractActor.ts +++ b/src/actors/runtime/AbstractActor.ts @@ -95,7 +95,7 @@ export default abstract class AbstractActor { async registerActorReminder<_Type>( reminderName: string, dueTime: Temporal.Duration, - period: Temporal.Duration, + period?: Temporal.Duration, ttl?: Temporal.Duration, state?: any, ) { @@ -115,7 +115,7 @@ export default abstract class AbstractActor { timerName: string, callback: string, dueTime: Temporal.Duration, - period: Temporal.Duration, + period?: Temporal.Duration, ttl?: Temporal.Duration, state?: any, ) { diff --git a/src/types/ActorReminder.type.ts b/src/types/ActorReminder.type.ts old mode 100644 new mode 100755 index 0f010d2c..c5d0614a --- a/src/types/ActorReminder.type.ts +++ b/src/types/ActorReminder.type.ts @@ -14,7 +14,7 @@ limitations under the License. import { Temporal } from "@js-temporal/polyfill"; export type ActorReminderType = { - period: Temporal.Duration; // e.g. 0h0m9s0ms + period?: Temporal.Duration; // e.g. 0h0m9s0ms dueTime?: Temporal.Duration; // e.g. 1m or 0h0m0s0ms defaults to 0s data?: any; // the data to pass ttl?: Temporal.Duration; // e.g. 1m diff --git a/src/types/ActorTimer.type.ts b/src/types/ActorTimer.type.ts old mode 100644 new mode 100755 index 9c29d258..ed8b5899 --- a/src/types/ActorTimer.type.ts +++ b/src/types/ActorTimer.type.ts @@ -14,7 +14,7 @@ limitations under the License. import { Temporal } from "@js-temporal/polyfill"; export type ActorTimerType = { - period: Temporal.Duration; // e.g. 0h0m9s0ms + period?: Temporal.Duration; // e.g. 0h0m9s0ms dueTime?: Temporal.Duration; // e.g. 1m or 0h0m0s0ms defaults to 0s data?: any; // the data to pass ttl?: Temporal.Duration; // e.g. 1m