fix flaky integration test DemoActorReminderOnceImpl (dapr#553)

* add undefined type Signed-off-by: MregXN <[email protected]> * npm run pretty-fix Signed-off-by: MregXN <[email protected]> * add undefind type for ttl Signed-off-by: MregXN <[email protected]> * add undefind type Signed-off-by: MregXN <[email protected]> * make type optional Signed-off-by: MregXN <[email protected]> --------- Signed-off-by: MregXN <[email protected]>
MregXN · Nov 27, 2023 · d33c5a4 · d33c5a4
1 parent 2d41bc8
commit d33c5a4
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/daprdocs/content/en/js-sdk-docs/js-server/_index.md b/daprdocs/content/en/js-sdk-docs/js-server/_index.md
@@ -112,8 +112,8 @@ const daprServer = new DaprServer({
       serverPort: "50002", // App Port
       serverHttp: myApp,
       clientOptions: {
-        daprHost,
-        daprPort,
+        daprHost
+        daprPort
       }
     });
 

diff --git a/src/actors/runtime/AbstractActor.ts b/src/actors/runtime/AbstractActor.ts
@@ -95,7 +95,7 @@ export default abstract class AbstractActor {
   async registerActorReminder<_Type>(
     reminderName: string,
     dueTime: Temporal.Duration,
-    period: Temporal.Duration,
+    period?: Temporal.Duration,
     ttl?: Temporal.Duration,
     state?: any,
   ) {
@@ -115,7 +115,7 @@ export default abstract class AbstractActor {
     timerName: string,
     callback: string,
     dueTime: Temporal.Duration,
-    period: Temporal.Duration,
+    period?: Temporal.Duration,
     ttl?: Temporal.Duration,
     state?: any,
   ) {

diff --git a/src/types/ActorReminder.type.ts b/src/types/ActorReminder.type.ts
@@ -14,7 +14,7 @@ limitations under the License.
 import { Temporal } from "@js-temporal/polyfill";
 
 export type ActorReminderType = {
-  period: Temporal.Duration; // e.g. 0h0m9s0ms
+  period?: Temporal.Duration; // e.g. 0h0m9s0ms
   dueTime?: Temporal.Duration; // e.g. 1m or 0h0m0s0ms defaults to 0s
   data?: any; // the data to pass
   ttl?: Temporal.Duration; // e.g. 1m

diff --git a/src/types/ActorTimer.type.ts b/src/types/ActorTimer.type.ts
@@ -14,7 +14,7 @@ limitations under the License.
 import { Temporal } from "@js-temporal/polyfill";
 
 export type ActorTimerType = {
-  period: Temporal.Duration; // e.g. 0h0m9s0ms
+  period?: Temporal.Duration; // e.g. 0h0m9s0ms
   dueTime?: Temporal.Duration; // e.g. 1m or 0h0m0s0ms defaults to 0s
   data?: any; // the data to pass
   ttl?: Temporal.Duration; // e.g. 1m