Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Advancement Crashes #57

Open
AbrasiveBoar902 opened this issue Mar 3, 2023 · 2 comments
Open

Sync Advancement Crashes #57

AbrasiveBoar902 opened this issue Mar 3, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@AbrasiveBoar902
Copy link

AbrasiveBoar902 commented Mar 3, 2023

Maybe because writeAdvancementData modifies advancementToProgress(or other LinkedHashMaps) while PlayerAdvancementTracker/sendUpdate is reading it with iterator.

Caused

Description: Ticking entity

java.util.ConcurrentModificationException
at java.base/java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:756)
at java.base/java.util.LinkedHashMap$LinkedKeyIterator.next(LinkedHashMap.java:778)
at net.minecraft.class_2985.method_12876(class_2985.java:285)
at net.minecraft.class_3222.method_5773(class_3222.java:428)
at net.minecraft.class_3218.method_18762(class_3218.java:621)
at net.minecraft.class_1937.method_18472(class_1937.java:561)
at net.minecraft.class_3218.method_18765(class_3218.java:411)
at net.minecraft.server.MinecraftServer.redirect$zkm000$ficUpdateSuppressionCrashTick(MinecraftServer.java:3711)
at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:871)
at net.minecraft.class_3176.method_3813(class_3176.java:312)
at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:811)
at net.minecraft.server.MinecraftServer.handler$zbc000$modifiedRunLoop(MinecraftServer.java:2810)
at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:651)
at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:257)
at java.base/java.lang.Thread.run(Thread.java:833)
@MrNavaStar
Copy link
Owner

Oh pain, I'm surprised this has never come up. I'll look into fixing this hopefully this weekend.

@MrNavaStar MrNavaStar changed the title Crash Caused Sync Advancement Crashes Mar 7, 2023
@MrNavaStar MrNavaStar added the bug Something isn't working label Apr 17, 2023
@MrNavaStar
Copy link
Owner

MrNavaStar commented May 6, 2023

Do you have any more logs you can share with me? Or any steps to reproduce the error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants