Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

voxel_vote is slow #50

Open
bcdarwin opened this issue Apr 27, 2022 · 1 comment
Open

voxel_vote is slow #50

bcdarwin opened this issue Apr 27, 2022 · 1 comment

Comments

@bcdarwin
Copy link
Member

Currently voxel_vote makes len(dimension 0) * n_files calls to getHyperslab, resulting in a quite a number of I/O syscalls. It would be better to read in each file at a time and maintain a (sparse) label histogram at each voxel.

(One minor question is how to store the histograms, e.g. some sparse array format with a channels dimension for the label histograms seems appropriate, but it might be necessary to determine the maximum label in advance.)

@gdevenyi
Copy link

we did a sort of histogram thing which also enabled counting making weighted voting,
https://github.com/CoBrALab/antsRegistration-MAGeT/blob/master/bin/simpleitk_weighted_vote.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants