Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal: Add support for .modal-dialog-scrollable #61

Closed
modmatrix opened this issue Jan 21, 2020 · 3 comments · Fixed by #64
Closed

Modal: Add support for .modal-dialog-scrollable #61

modmatrix opened this issue Jan 21, 2020 · 3 comments · Fixed by #64

Comments

@modmatrix
Copy link

It'd be nice (and pretty easy) to add support for the .modal-dialog-scrollable class:

https://getbootstrap.com/docs/4.4/components/modal/#scrolling-long-content

Right now, it isn't possible to use this feature without resorting to hacks.

(I might submit a pull request for this when I have time – this issue is just a reminder for myself, or someone else, to do that.)

@videk1
Copy link

videk1 commented Jun 15, 2020

Please add support for this. Much needed!

@Morgul
Copy link
Owner

Morgul commented Jun 25, 2020

I would be fine if someone wants to add that. I'll gladly review the code and merge it in. I, however, am doing active development on this project, so this will have to come from the community.

DaleCam pushed a commit to DaleCam/ui-bootstrap4 that referenced this issue Oct 7, 2020
Adds optional property scrollable to modal. Fixes issue Morgul#61
@Morgul Morgul linked a pull request Oct 8, 2020 that will close this issue
@doublesharp
Copy link

@Morgul - this tripped me up because in the 3.0.7 version the dist/ui-bootstrap.js version is still at 3.0.6. The 3.0.7 ones have the version in the filename, but it was unexpected for them to not match, so by including the file without the version in the name this functionality was missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants