Fix failing tests #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Starkware devs want to use the bootloader with upstream cairo-vm for their own use case. Solution: migrate all hints from our fork of `cairo-vm` and add a `BootloaderHintProcessor` struct that users can then import and add to their own hint processing logic. Limitations: * the tests do not work yet, we need to modify test code that relies on internal cairo-vm test macros. * the bootloader is not yet compiled and provided as part of the library.
Problem: Starkware devs want to use the bootloader with upstream cairo-vm for their own use case. Solution: migrate all hints from our fork of `cairo-vm` and add a `BootloaderHintProcessor` struct that users can then import and add to their own hint processing logic. Limitations: * the tests do not work yet, we need to modify test code that relies on internal cairo-vm test macros. * the bootloader is not yet compiled and provided as part of the library.
…oader into feat/fix-tests
odesenfans
suggested changes
Jun 5, 2024
odesenfans
suggested changes
Jun 6, 2024
src/macros.rs
Outdated
| }}; | ||
| } | ||
| #[macro_export] | ||
| macro_rules! references { |
odesenfans
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
This attempts to get all the tests passing.
Pending Tasks
Breaking changes?