Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify Moonshine About New Instances #86

Open
JoelProminic opened this issue Aug 14, 2023 · 0 comments
Open

Notify Moonshine About New Instances #86

JoelProminic opened this issue Aug 14, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@JoelProminic
Copy link
Contributor

@rat-moonshine has been working on Moonshine logic to detect SHI servers. This is working on macOS (on a branch build).

To complement this, I would like to have SHI call Moonshine (and MoonshineDevelopment) to notify it when there are new servers available. This is similar to the messages MSDKI sends to Moonshine, which @rat-moonshine linked here.

I expect this to trigger at least when a server finishes initial provisioning. Moonshine will automatically avoid duplicate entries, so it is not a problem to trigger this in other cases, but I would prefer that the server at least be running when the update is triggered. If this message triggers focus on Moonshine regardless of whether instances are updated, we will need to be more careful about when the messages are sent.

NOTE: the imported "Vagrant Instance" won't work from Moonshine until the user updates their hosts file. Unfortunately, this means that any new servers will automatically fail to connect in Moonshine when the above message triggers. I don't see a better time for us to update this, though, since SHI does not know when the hosts file is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants