Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyses cause check-model-has-description failure #18

Open
tim-steinkuhler opened this issue Nov 24, 2022 · 0 comments
Open

Analyses cause check-model-has-description failure #18

tim-steinkuhler opened this issue Nov 24, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@tim-steinkuhler
Copy link

Describe the bug
When I added an analysis file accompanied by a yaml file with a description, check-model-has-description still fails, saying it doesn't have a description.

This can be fixed by either excluding analyses from this check or correctly looking for analysis descriptions.

To Reproduce
Steps to reproduce the behavior:

  1. Install codegen with dbt deps
  2. Create a sql file in the analyses folder, and a yaml file with a description
  3. run the check-model-has-description check
# packages.yml
packages:
  - package: dbt-labs/codegen
    version: 0.8.1
--generate_model_yaml.sql
{{ codegen.generate_model_yaml(
    model_name='base_trengo_tickets_tickets_custom_data'
) }}
# generate_model_yaml.yml
version: 2
analyses:
  - name: generate_model_yaml
    description: >
        This analyses generates the input necessary for a .yml file,
        by adding the model name without extensions and then hit compile.
        The output can then be copied and pasted into the designated yml file.
# .pre-commit-config.yaml
 - repo: https://github.com/Montreal-Analytics/dbt-gloss
    rev: v1.0.0
    hooks:
      - id: dbt-deps
      - id: dbt-compile
      - id: dbt-run
      - id: dbt-docs-generate
      # Check the model has description.
      - id: check-model-has-description

afbeelding

Expected behavior
I expect check to pass

Version:
v1.0.0

@tim-steinkuhler tim-steinkuhler added the bug Something isn't working label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant