Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common modelines more easily #90

Closed
1 task done
xieve opened this issue Feb 25, 2024 · 5 comments
Closed
1 task done

Add common modelines more easily #90

xieve opened this issue Feb 25, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@xieve
Copy link

xieve commented Feb 25, 2024

Prerequisites

Please answer the following questions for yourself before submitting an issue.

  • I checked to make sure that this request has not already been filed

Description

Is your feature request related to a problem? Please describe.
I am using Sunshine & Moonlight to stream from my desktop to my laptop and my phone. These two scripts enable me to have a near seamless experience together with virtual-display-rs, provided the resolution of my client corresponds with one of the resolutions I have set. If not, I need to find out what the resolution of my client is and set it. Ideally, I'd be able to set a resolution in Moonlight and if it were not completely uncommon, it would be set on my desktop before connecting. I could also set half the resolution to conserve power and bandwidth.

Describe the solution you'd like
If there was an option to just add most modelines to my virtual monitor with one click, that would be great.

Describe alternatives you've considered
Theoretically, the script author might integrate with virtual-display-rs more tightly and set the resolutions directly. That would be most ideal, but given the simplistic nature of the project, I believe that's rather unrealistic.

Obviously, I can just add all the modelines myself, this is not a huge inconvenience to me, but it is one. Alternatively, a list of common modelines to choose from would also be practical. It could have an "add all" button, maybe.

@xieve xieve added the enhancement New feature or request label Feb 25, 2024
@MolotovCherry
Copy link
Owner

I plan to make scripting support for this (e.g. with python), would that help out a bit with freedom?

@xieve
Copy link
Author

xieve commented Feb 25, 2024

Yes, that'd be cool. Maybe just a simple CLI wrapper around your core logic? Like

VirtualDisplayDriverControl.exe --add 1920x1080x60
VirtualDisplayDriverControl.exe --remove 1920x1080x60

I can see other how other remote desktop solutions could utilize this quite easily, too.

@MolotovCherry
Copy link
Owner

MolotovCherry commented Feb 25, 2024

If what you wanted was a cli wrapper, there's already one in master, see here:
#60

Both cli and scripting support will be available

(There's actually already a working python module in master too, but I want to rework it)

@MolotovCherry
Copy link
Owner

MolotovCherry commented Apr 9, 2024

@xieve Python bindings are finished and stable now if you want to try them out. I assume that between the cli and python bindings, this report is probably solved by them

@MolotovCherry
Copy link
Owner

MolotovCherry commented Apr 14, 2024

I'm going to close this as it seems to be solved by both the python bindings and existing cli. There's an issue report which has a link to updated builds if you want to try it out.

Feel free to comment back onto this issue report #115 if you have any more thoughts/concerns. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants