Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov may not be finding configuration file #91

Open
j-wags opened this issue Oct 3, 2019 · 0 comments
Open

Codecov may not be finding configuration file #91

j-wags opened this issue Oct 3, 2019 · 0 comments

Comments

@j-wags
Copy link
Contributor

j-wags commented Oct 3, 2019

Repost of https://github.com/openforcefield/openforcefield/pull/432/files#r331088966

I haven't verified this directly (by making a new repo using the cookiecutter), but will update this Issue when I do so.

Basically, I removed our old coverage version pin, and codecov dropped by 30%. This was due to the code lines in the tests themselves becoming a part of the denominator for our coverage % (but oddly, not the numerator).

Per the docs here, this can be avoided using the [omit] keyword in a config file. This is present both in the OFFTK repo and in the cookiecutter, in setup.cfg. However, our pytest commands (and the cookiecutter's) don't specifically point to this file (using the --cov-config commandline argument).

I suspect that new versions of coverage or pytest-cov have changed the way that config files are found, such that setup.cfg is no longer found by default. Adding --cov-config=setup.cfg to the list of pytest args should fix that if it's also an issue in the cookiecutter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant