Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner 1.20.1 - CUSTOM NPCS - BUG WHEN EDITING AND SAVING NPCS #317

Open
5 tasks done
JavierLobosS opened this issue Oct 3, 2024 · 0 comments
Open
5 tasks done

Comments

@JavierLobosS
Copy link

JavierLobosS commented Oct 3, 2024

I have confirmed that ...

  • Banner is up to date
  • all dependencies are installed
  • all plugins and mods are up to date
  • unable to reproduce in Spigot
  • unable to reproduce in Fabric

Banner version

Banner 1.20.1 - 728

OS & Java versions

Windows11 Java 20.0.2

Plugins and Mods

Custom NPCS 1.20.1 FABRIC
Fabric API 0.92.2+1.20.1

You can download CustomNPCs from here:
https://discord.com/channels/151785576557707264/423946043395407882/1279717897899610162

Description

I have been testing the CustomNPCs mod for Fabric, and it works perfectly in both single-player and regular multiplayer modes. However, when I try to use banners, an error occurs that prevents me from editing or saving the NPCs. I reached out to the developer, and they mentioned that the issue might be related to the hybrid mode. Could you please provide a solution regarding this?

Step to reproduce

Step 1: Install CustomNPCs with banners.
Step 2: Create an NPC with the wand.
Step 3: Close the window, and you won't be able to edit it.
Step 4: Use the soulstone or mob cloner to try to save the NPC

2024-09-16.19-53-59.mp4

Logs

latest.log

[21:56:53] [Server thread/ERROR]: Error executing task on Server
java.lang.NullPointerException: Cannot read field "field_18250" because the return value of "it.unimi.dsi.fastutil.ints.Int2ObjectMap.get(int)" is null
at noppes.npcs.packets.Packets.sendNearby(Packets.java:250) ~[CustomNPCs-Unofficial-Fabric-1.20.1.20240901.jar:?]
at noppes.npcs.packets.server.SPacketRemoteNpcDelete.handle(SPacketRemoteNpcDelete.java:39) ~[CustomNPCs-Unofficial-Fabric-1.20.1.20240901.jar:?]
at noppes.npcs.packets.PacketServerBasic.lambda$handle$0(PacketServerBasic.java:48) ~[CustomNPCs-Unofficial-Fabric-1.20.1.20240901.jar:?]
at net.minecraft.class_3738.run(class_3738.java:18) ~[server-intermediary.jar:?]
at net.minecraft.class_1255.method_18859(class_1255.java:156) ~[server-intermediary.jar:?]
at net.minecraft.class_4093.method_18859(class_4093.java:23) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_24306(MinecraftServer.java:782) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_18859(MinecraftServer.java:164) ~[server-intermediary.jar:?]
at net.minecraft.class_1255.method_16075(class_1255.java:130) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_20415(MinecraftServer.java:764) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_16075(MinecraftServer.java:758) ~[server-intermediary.jar:?]
at net.minecraft.class_1255.method_18857(class_1255.java:139) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_16208(MinecraftServer.java:743) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:2107) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:265) ~[server-intermediary.jar:?]
at java.lang.Thread.run(Thread.java:1623) ~[?:?]

Server pack link (Optional)

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant